Re: Git.pm with recent File::Temp fail

On Sat, 23 Mar 2013 16:32:47 +0000, Ben Walton [off-list ref]
wrote:

Hello,

Still failing in 1.8.2.1

On Fri, Mar 22, 2013 at 7:57 PM, H.Merijn Brand [off-list ref] wrote:

quoted

git-1.8.2, perl-5.16.3, File::Temp-0.23

Without patch:

$ git svn fetch
'tempfile' can't be called as a method at /pro/lib/perl5/site_perl/5.16.3/Git.pm line 1117.

After patch:

$ git svn fetch
        M       t/06virtual.t
r15506 = 6c65be7ff36ffc6fd9b960a4b470ca297103004e (refs/remotes/git-svn)
⋮

patch attached

This list prefers patches to be inline so that they can easily be
commented on, etc.  I took a quick look at your patch and while it
looks fine to me, fwiw.

You may want to resubmit using git send-email though so that others
will look at it and possibly apply it.

-- 
H.Merijn Brand  http://tux.nl   Perl Monger  http://amsterdam.pm.org/
using perl5.00307 .. 5.17   porting perl5 on HP-UX, AIX, and openSUSE
http://mirrors.develooper.com/hpux/        http://www.test-smoke.org/
http://qa.perl.org   http://www.goldmark.org/jeff/stupid-disclaimers/