Re: [PATCH 1/2] bundle: Accept prerequisites without commit messages

Junio C Hamano [off-list ref] writes:

Lukas Fleischer [off-list ref] writes:

quoted

While explicitly stating that the commit message in a prerequisite
line is optional, 

Good spotting.  What e9ee84cf28b6 (bundle: allowing to read from an
unseekable fd, 2011-10-13) meant to say was the SP was optional but

s/say was the SP was optional/say was not the SP was optional/

we want to allow a tip bundled to have a commit without any commit
log message (hence making it "optional"), and the check you are
looking at does try to enforce.  What was buggy was that the
comparison did not take into account that the codepath earlier
called rtrim() on it, stripping "-<object name>SP<eol>" of the
trailing SP it wants to look for.