Re: [PATCH v2 1/2] send-email: make annotate configurable
From: Junio C Hamano <hidden>
Date: 2016-06-15 22:56:42
Felipe Contreras [off-list ref] writes:
quoted hunk ↗ jump to hunk
@@ -305,6 +306,7 @@ my $rc = GetOptions("h" => \$help, "smtp-domain:s" => \$smtp_domain, "identity=s" => \$identity, "annotate" => \$annotate, + "no-annotate" => \$no_annotate,
Wouldn't it be much better to let GetOptions know that --no-annotate is allowed by saying "annotate!" => \$annotate which also let us lose an extra $no_annotate variable?