Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH v2 2/2] format-patch: add format.cover-letter configuration

From: Matthieu Moy <hidden>
Date: 2016-06-15 22:56:42

Felipe Contreras [off-list ref] writes:
quoted
Perhaps you can clarify this: Controls whether to generate a
cover-letter when format-patch is invoked.  Can be true, false, or
auto.  "auto" generates a cover-letter only when generating more than
one patch.
That's good, but I believe if we say it's a boolean, true and false
are implied, and then we have an extra "auto".
At the moment, we don't say it's Boolean. I'm not sure it's a good idea
to say Boolean here, since it would also imply that there's no value
other than true and false.

Also, you should mention the default value. Something like "Set to true
to always generate a cover letter. Defaults to false." or so.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help