Re: [PATCH] http-backend: respect GIT_NAMESPACE with dumb clients
From: Junio C Hamano <hidden>
Date: 2016-06-15 22:56:41
Possibly related (same subject, not in this thread)
- 2016-06-15 · Re: [PATCH] http-backend: respect GIT_NAMESPACE with dumb clients · John Koleszar <hidden>
- 2016-06-15 · Re: [PATCH] http-backend: respect GIT_NAMESPACE with dumb clients · Thomas Rast <hidden>
- 2016-06-15 · Re: [PATCH] http-backend: respect GIT_NAMESPACE with dumb clients · Jeff King <hidden>
- 2016-06-15 · Re: [PATCH] http-backend: respect GIT_NAMESPACE with dumb clients · John Koleszar <hidden>
- 2016-06-15 · Re: [PATCH] http-backend: respect GIT_NAMESPACE with dumb clients · Junio C Hamano <hidden>
John Koleszar [off-list ref] writes:
quoted hunk
@@ -402,7 +404,8 @@ static void get_info_refs(char *arg) } else { select_getanyfile(); - for_each_ref(show_text_ref, &buf); + head_ref_namespaced(show_text_ref, &buf); + for_each_namespaced_ref(show_text_ref, &buf); send_strbuf("text/plain", &buf); }
Whether we are namespaced or not, we used to do for_each_ref() here, not advertising the HEAD (outside refs/ hierarchy), but we now do, and as the first element in the output. Am I reading the patch correctly? Is that an unrelated but useful bugfix even for people who do not use server namespaces?
quoted hunk
diff --git a/t/t5560-http-backend-noserver.sh b/t/t5560-http-backend-noserver.sh index ef98d95..85a5625 100755 --- a/t/t5560-http-backend-noserver.sh +++ b/t/t5560-http-backend-noserver.sh@@ -26,6 +26,13 @@ GET() { test_cmp exp act } +GET_BODY() { + REQUEST_METHOD="GET" && export REQUEST_METHOD && + run_backend "/repo.git/$1" && + sane_unset REQUEST_METHOD && + tr '\015' Q <act.out | sed '1,/^Q$/d' +} +
These "export/unset" in &&-chains will allow a failing test to affect the next test, but that is not a new problem (existing POST already has that problem). Just highlighting, so that interested people may notice and want to clean it up on top of this patch.
POST() {
REQUEST_METHOD="POST" && export REQUEST_METHOD &&
CONTENT_TYPE="application/x-$1-request" && export CONTENT_TYPE &&Thanks, will queue.