Re: [PATCH 2/2] diffcore-pickaxe: fill_one() doesn't modify textconv
From: Matthieu Moy <hidden>
Date: 2016-06-15 22:56:41
Simon Ruderich [off-list ref] writes:
quoted hunk
--- a/diffcore-pickaxe.c +++ b/diffcore-pickaxe.c@@ -75,10 +75,10 @@ static void diffgrep_consume(void *priv, char *line, unsigned long len) } static void fill_one(struct diff_filespec *one, - mmfile_t *mf, struct userdiff_driver **textconv) + mmfile_t *mf, struct userdiff_driver *textconv)
Nice, but perhaps you should elaborate a bit more in the commit message to say this is a cleanup without real change. -- Matthieu Moy http://www-verimag.imag.fr/~moy/