Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH 07/13] remote-hg: redirect buggy mercurial output

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:56:40

Felipe Contreras [off-list ref] writes:
I saw that you update the commit message without consulting here first to:

---
remote-hg: redirect unnecessary mercurial output
    
Mercurial emits messages like "searching for changes", "no changes
found", etc. meant for the use of its own UI layer, which is of no
use for our remote helper.  Squelch them.
---

This is not correct. This patch does _not_ squelch the output, it's redirecting
it to standard error, so the user actually sees it now, and we do that not
because the output is "unnecessary", but because it *breaks* the pipe between
the transport helper and remote helper. I'll reroll with the updated commit message.
I actually "consulted" by asking you what you meant by "buggy".  I
just misread/misunderstood your response in prose.

An update in the patch form obviously would not risk such a
misunderstanding ;-)

Thanks.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help