Thread (2 messages) flat view 2 messages, 2 authors, 2016-06-15

Re: [PATCH] t1300: document some aesthetic failures of the config editor

From: Jeff King <hidden>
Date: 2016-06-15 22:56:34

Possibly related (same subject, not in this thread)

On Fri, Mar 29, 2013 at 01:35:22PM -0700, Junio C Hamano wrote:
Jeff King [off-list ref] writes:
quoted
Here it is with the updated expectation. I don't care _that_ much, so if
you feel strongly and want to drop the first test, feel free.
As long as we are adding expect_failure without an immediate fix,
let's document the ideal, with this patch on top.
[...]
 test_expect_failure 'unsetting the last key in a section removes header' '
 	cat >.git/config <<-\EOF &&
+	# some generic comment on the configuration file itself
+	# a comment specific to this "section" section.
 	[section]
 	# some intervening lines
 	# that should also be dropped
 
 	key = value
 	EOF
 
-	>expect &&
+	cat >expect <<-\EOF &&
+	# some generic comment on the configuration file itself
+	EOF
I think we may not attain that ideal without some natural language
processing of the comments. But hey, no reason not to shoot for the
stars. :)

-Peff
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help