Thread (3 messages) flat view 3 messages, 3 authors, 2016-06-15

Re: [PATCH v2] git-send-email.perl: implement suggestions made by perlcritic

From: Jonathan Nieder <hidden>
Date: 2016-06-15 22:56:33

Possibly related (same subject, not in this thread)

Ramkumar Ramachandra wrote:
 Junio: In future, please tell me explicitly that you're expecting a
 re-roll with an updated commit message.  It wasn't obvious to me at
 all.
When there are questions in response to a patch, there are two
possibilities:

 * temporary brainfart --- sorry for the bother
 * the clarity of the patch or commit message has room for improvement

This wasn't a case of the former, so a seasoned contributor could
safely assume that it was definitely a case of the latter.

The explanation in Linux kernel's Documentation/SubmittingPatches
item 10 ("Don't get discouraged.  Re-submit") has some fitting advice.

Hope that helps,
Jonathan
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help