Re: [PATCH v2 1/4] Move commit GPG signature verification to commit.c
From: Junio C Hamano <hidden>
Date: 2016-06-15 22:56:30
Sebastian Götte [off-list ref] writes:
quoted hunk ↗ jump to hunk
Signed-off-by: Sebastian Götte <redacted> --- commit.c | 54 ++++++++++++++++++++++++++++++++++++++++++++++ commit.h | 9 ++++++++ gpg-interface.h | 6 ++++++ pretty.c | 67 +++++---------------------------------------------------- 4 files changed, 74 insertions(+), 62 deletions(-)diff --git a/commit.c b/commit.c index e8eb0ae..d0d9135 100644 --- a/commit.c +++ b/commit.c@@ -1023,6 +1023,60 @@ free_return: free(buf); } +static struct { + char result; + const char *check; +} signature_check[] = { + { 'G', ": Good signature from " }, + { 'B', ": BAD signature from " }, +};
This seems to be based on the old codebase. 4a868fd655a7 (pretty: parse the gpg status lines rather than the output, 2013-02-14) is already in 'master' for this cycle, and it is likely that we would want to have the same fix for 1.8.1.x maintenance track as well.