Re: [PATCH v2 2/3] t7800: fix tests when difftool uses --no-symlinks
From: Junio C Hamano <hidden>
Date: 2016-06-15 22:56:30
David Aguilar [off-list ref] writes:
This makes me wonder whether the modifiable mode should be made more explicit, either in the documentation or via a flag. Imagine if --dir-diff also honored --edit and --no-edit flags. Right now --edit is the default. If we had foreseen these various edge cases and unintended copy-backs then we may have initially chosen --no-edit as the default, but that's not really my point. What I'm thinking is that it might be good for the tool to learn --edit/--no-edit so that the symlink/copy-back heuristic can be documented alongside that option. Users can then know what to expect when using this mode. --no-edit would also be faster since it can avoid all these extra steps. It could also learn "difftool.dirDiffEditable" to control the default, which would eliminate the pain in needing to supply the flag on every invocation. What do you think about officially supporting a read-only mode?
Yeah, actually that was what I've been assuming the default (not suggesting to change the default behaviour here).