Re: [PATCH 4/6] remote.c: introduce a way to have different remotes for fetch/push
From: Jonathan Nieder <hidden>
Date: 2016-06-15 22:56:29
Ramkumar Ramachandra wrote:
This patch has no visible impact, but
serves to enable future patches to introduce configuration variables
to set pushremote_name. For example, you can now do the following in
handle_config():
if (!strcmp(key, "remote.pushdefault"))
git_config_string(&pushremote_name, key, value);Thanks. [...]
quoted hunk ↗ jump to hunk
--- a/builtin/push.c +++ b/builtin/push.c@@ -322,7 +322,7 @@ static int push_with_options(struct transport *transport, int flags) static int do_push(const char *repo, int flags) { int i, errs; - struct remote *remote = remote_get(repo); + struct remote *remote = pushremote_get(repo);
"struct remote" has url and pushurl fields. What do they mean in the context of these two accessors? /me is confused. Is the idea that now I should not use pushurl any more, and that I should use pushremote_get and use url instead? Hope that helps, Jonathan