Re: [PATCH 3/4] add -u: only show pathless 'add -u' warning when changes exist outside cwd
From: Jonathan Nieder <hidden>
Date: 2016-06-15 22:56:26
Possibly related (same subject, not in this thread)
- 2016-06-15 · Re: [PATCH 3/4] add -u: only show pathless 'add -u' warning when changes exist outside cwd · Jonathan Nieder <hidden>
- 2016-06-15 · Re: [PATCH 3/4] add -u: only show pathless 'add -u' warning when changes exist outside cwd · Junio C Hamano <hidden>
- 2016-06-15 · Re: [PATCH 3/4] add -u: only show pathless 'add -u' warning when changes exist outside cwd · Jonathan Nieder <hidden>
- 2016-06-15 · [PATCH 3/4] add -u: only show pathless 'add -u' warning when changes exist outside cwd · Jonathan Nieder <hidden>
- 2016-06-15 · Re: [PATCH 3/4] add -u: only show pathless 'add -u' warning when changes exist outside cwd · Matthieu Moy <hidden>
Junio C Hamano wrote:
The implemenation appears to run an extra diff_files() in addition to the one we already have to run in order to implement the "add -u" to collect modified/deleted paths. Is that the best we can do?
At least the following should be squashed in to avoid wasted effort in the easy case (cwd at top of worktree). Thanks for catching it.
diff --git i/builtin/add.c w/builtin/add.c
index f05ec1c1..8e4cdfae 100644
--- i/builtin/add.c
+++ w/builtin/add.c@@ -483,7 +483,7 @@ int cmd_add(int argc, const char **argv, const char *prefix) * "git add -u ." in the future. This warning prepares for * that change. */ - if (implicit_dot) + if (prefix && implicit_dot) diff_files_with_callback(prefix, NULL, warn_if_outside_pathspec, pathspec);