Re: [PATCH] status: hint the user about -uno if read_directory takes too long
From: Junio C Hamano <hidden>
Date: 2016-06-15 22:56:25
Subsystem:
the rest · Maintainer:
Linus Torvalds
Possibly related (same subject, not in this thread)
- 2016-06-15 · Re: [PATCH] status: hint the user about -uno if read_directory takes too long · Duy Nguyen <hidden>
- 2016-06-15 · Re: [PATCH] status: hint the user about -uno if read_directory takes too long · Torsten Bögershausen <hidden>
- 2016-06-15 · Re: [PATCH] status: hint the user about -uno if read_directory takes too long · Ramkumar Ramachandra <hidden>
- 2016-06-15 · Re: [PATCH] status: hint the user about -uno if read_directory takes too long · Junio C Hamano <hidden>
- 2016-06-15 · Re: [PATCH] status: hint the user about -uno if read_directory takes too long · Torsten Bögershausen <hidden>
Torsten Bögershausen [off-list ref] writes:
quoted
Or we can be more explicit and say # It took 2.58 seconds to search for untracked files. 'status -uno' # may speed it up, but you have to be careful not to forget to add # new files yourself (see 'git help status').Thanks, that looks good for me
OK, then I'll squash this in to the version queued to 'pu', but we should start thinking about merging these multi-line messages into one multi-line strings that is split by the output layer to help the localization folks, using something like strbuf_commented_addf() and strbuf_add_commented_lines().
diff --git a/wt-status.c b/wt-status.c
index 6e75468..53c2222 100644
--- a/wt-status.c
+++ b/wt-status.c@@ -1027,10 +1027,14 @@ void wt_status_print(struct wt_status *s) if (advice_status_u_option && 2000 < s->untracked_in_ms) { status_printf_ln(s, GIT_COLOR_NORMAL, ""); status_printf_ln(s, GIT_COLOR_NORMAL, - _("It took %.2f seconds to enumerate untracked files."), + _("It took %.2f seconds to enumerate untracked files." + " 'status -uno'"), s->untracked_in_ms / 1000.0); status_printf_ln(s, GIT_COLOR_NORMAL, - _("Consider the -u option for a possible speed-up?")); + _("may speed it up, but you have to be careful not" + " to forget to add")); + status_printf_ln(s, GIT_COLOR_NORMAL, + _("new files yourself (see 'git help status').")); } } else if (s->commitable) status_printf_ln(s, GIT_COLOR_NORMAL, _("Untracked files not listed%s"),