Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCHv4 6/6] git-send-email: use git credential to obtain password

From: Matthieu Moy <hidden>
Date: 2016-06-15 22:56:16

Michal Nazarewicz [off-list ref] writes:
+	$auth = Git::credential({
+		'protocol' => 'smtp',
+		'host' => join(':', $smtp_server, $smtp_server_port),
At this point, $smtp_server_port is not always defined. I just tested
and got

Use of uninitialized value $smtp_server_port in join or string at
git-send-email line 1077.

Other than that, the whole series looks good.

-- 
Matthieu Moy
http://www-verimag.imag.fr/~moy/
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help