Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH 05/13] Help.c: add list_common_guides_help() function

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:56:15

Philip Oakley [off-list ref] writes:
quoted
quoted
The first comment line fortells of patch 6 which can generate this .h
file.
The Huh? was about that one, not about reuse.  I do not want to see
a build artifact kept in the history without a good reason.
I'd copied it from generate-cmdlist.sh which is a common-cmd.h
dependency and was introduced by

commit a87cd02ce02e97083eb76eb8b9bfeb2e46800fd7
Author: Fredrik Kuivinen [off-list ref]
Date:   Thu Mar 9 17:24:19 2006 +0100

    Nicer output from 'git'

    [jc: with suggestions by Jan-Benedict Glaw]

    Signed-off-by: Fredrik Kuivinen [off-list ref]
    Signed-off-by: Junio C Hamano [off-list ref]
Looking at the change again, I do not see us adding a build artifact
(in the case of that patch, common-cmd.h) to our history.  Only the
recipe to generate that file exists there, which is the right thing
to do.

Why do we want common-guides.h which is clearly marked as "A
generated file" at its top in our history?  That was what made me
say "Huh?".
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help