Thread (4 messages) flat view 4 messages, 2 authors, 2016-06-15

Re: [PATCH 1/1] Fix date checking in case if time was not initialized.

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:56:15

Mike Gorchak [off-list ref] writes:
	if (tm->tm_hour < 0 || tm->tm_min < 0 || tm->tm_sec < 0)
		return -1;

So is_date() always return negative result for the text string where
date is placed before time like '2008-02-14 20:30:45'.
Yes, it returns this -1 on other platforms, but...
It must fail on
other platforms as well.
... the input '2008-02-14 20:30:45' still parses fine for others
(including me).  That is what is puzzling.

A shot in the dark: perhaps your time_t is unsigned?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help