Thread (4 messages) flat view 4 messages, 4 authors, 2016-06-15

Re: [PATCH v2] git-commit: populate the edit buffer with 2 blank lines before s-o-b

From: Jeff King <hidden>
Date: 2016-06-15 22:56:13

Possibly related (same subject, not in this thread)

On Fri, Feb 22, 2013 at 02:05:27PM -0800, Brandon Casey wrote:
From: Brandon Casey <redacted>

Before commit 33f2f9ab, 'commit -s' would populate the edit buffer with
a blank line before the Signed-off-by line.  This provided a nice
hint to the user that something should be filled in.  Let's restore that
behavior, but now let's ensure that the Signed-off-by line is preceded
by two blank lines to hint that something should be filled in, and that
a blank line should separate it from the Signed-off-by line.

Plus, add a test for this behavior.

Reported-by: John Keeping <redacted>
Signed-off-by: Brandon Casey <redacted>
---

How about something like this?
FWIW, as a casual reader of this series, I find this to be way easier
to follow than the previous round.

-Peff
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help