Thread (39 messages) flat view 39 messages, 3 authors, 2016-06-15

Re: [PATCHv2 06/10] pkt-line: share buffer/descriptor reading implementation

From: Jonathan Nieder <hidden>
Date: 2016-06-15 22:56:11

Jeff King wrote:
But is it noisy about a missing pipe? We do not get EPIPE for reading.
Ah, that makes more sense.

[...]
quoted
quoted
+		len = packet_read_from_buf(line, sizeof(line), &last->buf, &last->len);
+		if (len && line[len - 1] == '\n')
+			len--;
Was anything guaranteeing that buffer.len < 1000 before this change?
No. That's discussed in point (3) of the "implications" in the commit
message.
Thanks.  Sorry I missed it the first time.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help