Re: [PATCH v3 2/9] user-manual: Reorganize the reroll sections, adding 'git rebase -i'
From: Junio C Hamano <hidden>
Date: 2016-06-15 22:56:10
"W. Trevor King" [off-list ref] writes:
On Sun, Feb 17, 2013 at 06:23:11PM -0800, Junio C Hamano wrote:quoted
"W. Trevor King" [off-list ref] writes:quoted
[[rewriting-one-commit]] Rewriting a single commit -------------------------@@ -2552,71 +2558,81 @@ $ git commit --amend which will replace the old commit by a new commit incorporating your changes, giving you a chance to edit the old commit message first.... A lot of lines removed here ...quoted
+[[reordering-patch-series]]This change makes the [[rewriting-one-commit]] section say "We already saw you can do 'commit --amend'" and nothing else. It makes me wonder if the remaining section is worth keeping if we go this route.I think there should be some mention of `commit --amend` in the rewriting history section. It's a pretty straightforward idea though, so there's not all that much to say about it ;).
I do think teaching "commit --amend", "rebase" and "rebase -i" together makes sense. It just felt that the remaining piece on "commit --amend" looked too thin in the substance, but it may be a good change in the existing flow of text.