Re: [RFC/PATCH] shell: allow 'help' command to disable interactive shell

Jonathan Nieder [off-list ref] writes:

Junio C Hamano wrote:

quoted

Jonathan Nieder [off-list ref] writes:

quoted

quoted

How about this?

A patch on top could change the default "git-shell-commands is not
present" message if that seems worthwhile.

Hmph.

I wonder if rewording the message when git-shell-commmands directory
is not there may be a better first step (which actually could be the
last step)?

Maybe, but it's not a step that I'm interested in.  I don't think it
changes the desirability of the patch I sent.  They are independent.

What I thought I read in the log message was that you wanted to give
a better message telling the users that the site does _not_ allow an
interactive shell access.  I do not see how that is independent from
a message given from this codepath, where the side has forbidden
shell access by not having ~/git-shell-commands directory in the
first place.  Are you shooting for customizability?

Junio C Hamano wrote:

              Are you shooting for customizability?

Yes, and the ability to generate the message dynamically.

On Sun, Feb 10, 2013 at 08:32:47PM -0800, Jonathan Nieder wrote:

Junio C Hamano wrote:

quoted

              Are you shooting for customizability?

Yes, and the ability to generate the message dynamically.

As far as the default goes, I think the current one is OK, provided
there is an option to customize it (e.g., like your patch). Right now it
is just nonsensical to random users ("What? What in the world is
~/git-shell-commands?"). But once it is customizable, the main consumer
of the message is admins who say "What? Why isn't the git-shell I just
set up working?". The current message helps them diagnose the problem,
and when they are ready to accept connections from random users, they'll
want something customizable anyway.

-Peff