Re: [PATCHv6] Add contrib/credentials/netrc with GPG support
From: Junio C Hamano <hidden>
Date: 2016-06-15 22:56:05
Ted Zlatanov [off-list ref] writes:
Add Git credential helper that can parse netrc/authinfo files.
I think this line is redundant; we already know it on the Subject: line.
quoted hunk
This credential helper supports multiple files, returning the first one that matches. It checks file permissions and owner. For *.gpg files, it will run GPG to decrypt the file. Signed-off-by: Ted Zlatanov <redacted> --- ...diff --git a/contrib/credential/netrc/Makefile b/contrib/credential/netrc/Makefile new file mode 100644 index 0000000..18a924f --- /dev/null +++ b/contrib/credential/netrc/Makefile@@ -0,0 +1,12 @@ +test_netrc: + @(echo "bad data" | ./git-credential-netrc -f A -d -v) || echo "Bad invocation test, ignoring failure" + @echo "=> Silent invocation... nothing should show up here with a missing file" + @echo "bad data" | ./git-credential-netrc -f A get + @echo "=> Back to noisy: -v and -d used below, missing file" + echo "bad data" | ./git-credential-netrc -f A -d -v get + @echo "=> Look for any entry in the default file set" + echo "" | ./git-credential-netrc -d -v get + @echo "=> Look for github.com in the default file set" + echo "host=google.com" | ./git-credential-netrc -d -v get + @echo "=> Look for a nonexistent machine in the default file set" + echo "host=korovamilkbar" | ./git-credential-netrc -d -v get
Whose netrc is this reading? Don't we want all of them to have "-f A" and ship "A" (rename it to something more reasonable), so that anybody can notice when he tries to improve it and breaks it?