Thread (2 messages) flat view 2 messages, 2 authors, 2016-06-15

Re: [PATCH] Verify Content-Type from smart HTTP servers

From: Jeff King <hidden>
Date: 2016-06-15 22:56:04

On Wed, Feb 06, 2013 at 07:56:08AM -0800, Junio C Hamano wrote:
Jeff King [off-list ref] writes:
quoted
Is it worth having a strbuf_set* family of functions to match the
strbuf_add*? We seem to have these sorts of errors with strbuf from time
to time, and I wonder if that would make it easier (and more readable)
to do the right thing.
Possibly.

The callsite below may be a poor example, though; you would need the
_reset() even if you change the _addstr() we can see in the context
to _setstr() to make sure later strbuf_*(type) will start from a
clean slate when !t anyway, no?
Ah, true. Let's not worry about it, then.

-Peff
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help