Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH 1/3] Add contrib/credentials/netrc with GPG support

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:56:03

[administrivia: I would really wish you didn't put "Mail-copies-to:
never" above].

Ted Zlatanov [off-list ref] writes:
+foreach my $v (values %{$options{tmap}})
+{
+ $options{tmap}->{$v} = $v;
+}
Please follow the styles of existing Perl scripts, e.g. indent with
tab, etc.  Style requests are not optional; it is a prerequisite to
make the patch readable and reviewable.
+ print <<EOHIPPUS;
+ ...
+EOHIPPUS
Do we really need to refer readers to Wikipedia or something to
learn about extinct equid ungulates ;-)?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help