Re: [PATCH 0/5] Fix msvc build
From: Junio C Hamano <hidden>
Date: 2016-06-15 22:56:01
Johannes Schindelin [off-list ref] writes:
Hi Ramsay, On Thu, 31 Jan 2013, Ramsay Jones wrote:quoted
As I mentioned recently, while discussing a cygwin specific patch (see "Version 1.8.1 does not compile on Cygwin 1.7.14" thread), the MSVC build is broken for me. The first 4 patches fix the MSVC build for me. The final patch is not really related to fixing the build, but it removed some make warnings which were quite irritating ...Thanks!quoted
Note that I used the Makefile, with the Visual C++ 2008 command line compiler on Windows XP (SP3), to build a vanilla git on MinGW. I'm not subscribed to the msysgit mailing list, nor do I follow the msysgit fork of git, so these patches may conflict with commits in their repository.Maybe you can Cc: the patch series to msysgit@googlegroups.com nevertheless?
OK. The only thing I can say about these patches is that none of them would affect my boxes would exercise, so I'll wait until I get a final-for-application re-send from mysgit folks, preferrably with their Acked-by: lines. Thanks.