Re: [PATCH v3 10/11] format-patch: update append_signoff prototype
flat view
From: Jonathan Nieder <hidden>
Date: 2016-06-15 22:55:55
Brandon Casey wrote:
From: Nguyễn Thái Ngọc Duy <redacted> This is a preparation step for merging with append_signoff from sequencer.c
Avoids a small unfreed allocation, too. Neat. Reviewed-by: Jonathan Nieder <redacted> (On the other hand, this means more malloc churn when running "format-patch -s" on a long series of patches, but I don't think anyone will mind.) [...]
quoted hunk ↗ jump to hunk
--- a/builtin/log.c +++ b/builtin/log.c@@ -1193,16 +1192,6 @@ int cmd_format_patch(int argc, const char **argv, const char *prefix) rev.subject_prefix = strbuf_detach(&sprefix, NULL); } - if (do_signoff) { - const char *committer; - const char *endpos; - committer = git_committer_info(IDENT_STRICT);
sequencer.c uses fmt_name() which uses IDENT_STRICT, too. Phew.