Re: [PATCH v2] add: warn when -u or -A is used without filepattern
From: Matthieu Moy <hidden>
Date: 2016-06-15 22:55:55
Junio C Hamano [off-list ref] writes:
Matthieu Moy [off-list ref] writes:quoted
Most git commands that can be used with our without a filepattern are tree-wide by default, the filepattern being used to restrict their scope. A few exceptions are: 'git grep', 'git clean', 'git add -u' and 'git add -A'. The inconsistancy of 'git add -u' and 'git add -A' are particularlys/consistan/consisten/;
Thanks, will fix.
I wonder if we want to say in the message
The behaviour of 'git add --all (or -A)'...
otherwise people who typed "git add -A" and got this message with
just "--all" may go "Huh?" for a brief moment. I however do not
think replacing these strings to
option_with_implicit_dot = "--all (-A)";
is a solution, given they are goven to _("l10n template %s").Plus, option_with_implicit_dot is used in cut-and-paste ready commands below. I can easily add another variable short_option or so to display both. Ideally, we should use whatever the user had typed, but that does not seem easy to do with parse-option so I'd say it's overkill. -- Matthieu Moy http://www-verimag.imag.fr/~moy/