Thread (2 messages) flat view 2 messages, 2 authors, 2016-06-15

Re: [PATCH] t9902: protect test from stray build artifacts

From: Jeff King <hidden>
Date: 2016-06-15 22:55:53

On Thu, Jan 24, 2013 at 08:11:07PM -0800, Junio C Hamano wrote:
Jeff King [off-list ref] writes:
quoted
This looks good to me.

The only thing I might add is a test just to double-check that "git help
-a" is parsed correctly. Like:

  test_expect_success 'command completion works without test harness' '
           GIT_TESTING_COMMAND_COMPLETION= run_completion "git bun" &&
           grep "^bundle\$" out
  '

(we know we are running bash here, so the one-shot variable is OK to be
used with a function).
I think you meant "^bundle $" there, but don't we have the same
problem when there is an end-user subcommand "git bunny"?

Ahh, ok, we show one element per line and just make sure "bundle"
is there, and we do not care what other buns appear in the output.
Exactly. At least that was the intent; I typed it straight into my MUA. :)

-Peff
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help