Thread (2 messages) flat view 2 messages, 2 authors, 2016-06-15

Re: Bug in latest gitk - can't click lines connecting commits

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:55:51

Paul Mackerras [off-list ref] writes:
On Tue, Jan 01, 2013 at 06:54:23PM +0100, Stefan Haller wrote:
quoted
Jason Holden [off-list ref] wrote:
quoted
I was testing some patches against the latest gitk, and noticed that when I
click the mouse on the lines that connect the commits in the history graph,
I get an error popup with:
 Error: can't read "cflist_top": no such variable

Looks like this was introduced in gitk commit b967135d89e8d8461d059
 gitk: Synchronize highlighting in file view when scrolling diff
A patch that fixes this was proposed over two months ago, and Paul said
he had applied it:

  <http://permalink.gmane.org/gmane.comp.version-control.git/208162>

However, looking at git://ozlabs.org/~paulus/gitk.git it's not there.
Paul?
I just forgot to push it out.  It's there now.
I notice that I have a handful of commits that I haven't pulled from
your repository, and the last commit on your 'master' is about 20
days old.  Is it safe for me to pull these now?

I can teach myself that your push is your pull-request, but I do not
think we agreed to arrange it that way yet, so...
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help