Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH 1/2] Update :/abc ambiguity check

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:55:50

Duy Nguyen [off-list ref] writes:
quoted
quoted
... take ":/abc" as rev even it's ambiguous. This patch makes it:

- ambiguous when "abc" exists on worktree
- a rev if abc does not exist on worktree
- a path if abc is not found in any commits (although better use
The "any commits" above sounds very scary. Are you really going to
check against all the commits?
If I remember correctly :/ will search through commit chains until it
finds a commit that matches. So :/non-existent-string definitely
searches through all commits.
That is the real work the user asked us to do, so it is not a wasted
latency.  The description looked as if you were doing extra work
only for disambiguation, which triggered my "Huh?" meter.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help