Thread (2 messages) flat view 2 messages, 2 authors, 2016-06-15

Re: [PATCH 03/19] reset.c: pass pathspec around instead of (prefix, argv) pair

From: Duy Nguyen <hidden>
Date: 2016-06-15 22:55:42

On Thu, Jan 10, 2013 at 2:26 AM, Junio C Hamano [off-list ref] wrote:
Martin von Zweigbergk [off-list ref] writes:
quoted
We use the path arguments in two places in reset.c: in
interactive_reset() and read_from_tree(). Both of these call
get_pathspec(), so we pass the (prefix, arv) pair to both
functions. Move the call to get_pathspec() out of these methods, for
two reasons: 1) One argument is simpler than two. 2) It lets us use
the (arguably clearer) "if (pathspec)" in place of "if (i < argc)".
---
If I understand correctly, this should be rebased on top of
nd/parse-pathspec. Please let me know.
Yeah, this will conflict with the get_pathspec-to-parse_pathspec
conversion Duy has been working on.
Or I could hold off nd/parse-pathspec if this series has a better
chance of graduation first. Decision?
-- 
Duy
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help