Re: [PATCH] gitk: Display the date of a tag in a human friendly way.

Hi Junio,

On 4 January 2013 23:50, Junio C Hamano [off-list ref] wrote:

Anand Kumria [off-list ref] writes:

quoted

By selecting a tag within gitk you can display information about it.
This information is output by using the command

 'git cat-file tag <tagid>'

This outputs the *raw* information from the tag, amongst which is the
time - in seconds since the epoch. As useful as that value is, I find it
a lot easier to read and process time which it is something like:

 "Mon Dec 31 14:26:11 2012 -0800"

This change will modify the display of tags in gitk like so:

  @@ -1,7 +1,7 @@
   object 5d417842efeafb6e109db7574196901c4e95d273
   type commit
   tag v1.8.1
  -tagger Junio C Hamano [off-list ref] 1356992771 -0800
  +tagger Junio C Hamano [off-list ref] Mon Dec 31 14:26:11 2012 -0800

   Git 1.8.1
   -----BEGIN PGP SIGNATURE-----

Signed-off-by: Anand Kumria <redacted>
---

Sounds like a sensible thing to do but I didn't check how else
(other than purely for displaying) this string is used.

As far as I can tell it is only used for display (cached_tagcontent in
gitk) purposes.

Paul, the patch is not made against your tree, so if you choose to
take it you would need to strip the leading directory at the top.

Sorry, I didn't know that gitk had been split back out (and
Documentation/gitk.txt still mentions it is part of the git suite).

Regards,
Anand