Re: [PATCH v3 18/19] setup.c: document get_pathspec()

On Fri, Dec 28, 2012 at 8:40 PM, Adam Spiers [off-list ref] wrote:

On Fri, Dec 28, 2012 at 8:36 PM, Junio C Hamano [off-list ref] wrote:

quoted

Adam Spiers [off-list ref] writes:

quoted

Since we have just created a new pathspec-handling library, now is a
good time to add some comments explaining get_pathspec().

Signed-off-by: Adam Spiers <redacted>
---

Yes, but we would rather not to see new users of this function added
to our codebase in its current form, as explained in the nearby
comment.  We would want to migrate everybody to "struct pathspec"
based interface to support magic pathspecs in the longer term.

I see.  Please feel free to drop that patch from the series or amend
as you see fit.

I've added this sentence to the top of the comments above
get_pathspec():

    /*
     * N.B. get_pathspec() is deprecated in favor of the "struct pathspec"
     * based interface - see pathspec_magic above.
     *
    [...]

That should be sufficient to discourage people from adding new users
of get_pathspec().