[PATCH v2 2/9] wildmatch: replace variable 'special' with better named ones
From: Nguyễn Thái Ngọc Duy <hidden>
Date: 2016-06-15 22:55:36
Subsystem:
the rest · Maintainer:
Linus Torvalds
'special' is too generic and is used for two different purposes. Replace it with 'match_slash' to indicate "**" pattern and 'negated' for "[!...]" and "[^...]". Signed-off-by: Nguyễn Thái Ngọc Duy <redacted> --- wildmatch.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/wildmatch.c b/wildmatch.c
index 3972e26..8a58ad4 100644
--- a/wildmatch.c
+++ b/wildmatch.c@@ -60,7 +60,7 @@ static int dowild(const uchar *p, const uchar *text, int force_lower_case) uchar p_ch; for ( ; (p_ch = *p) != '\0'; text++, p++) { - int matched, special; + int matched, match_slash, negated; uchar t_ch, prev_ch; if ((t_ch = *text) == '\0' && p_ch != '*') return ABORT_ALL;
@@ -102,15 +102,15 @@ static int dowild(const uchar *p, const uchar *text, int force_lower_case) if (p[0] == '/' && dowild(p + 1, text, force_lower_case) == MATCH) return MATCH; - special = TRUE; + match_slash = TRUE; } else return ABORT_MALFORMED; } else - special = FALSE; + match_slash = FALSE; if (*p == '\0') { /* Trailing "**" matches everything. Trailing "*" matches * only if there are no more slash characters. */ - if (!special) { + if (!match_slash) { if (strchr((char*)text, '/') != NULL) return NOMATCH; }
@@ -120,9 +120,9 @@ static int dowild(const uchar *p, const uchar *text, int force_lower_case) if (t_ch == '\0') break; if ((matched = dowild(p, text, force_lower_case)) != NOMATCH) { - if (!special || matched != ABORT_TO_STARSTAR) + if (!match_slash || matched != ABORT_TO_STARSTAR) return matched; - } else if (!special && t_ch == '/') + } else if (!match_slash && t_ch == '/') return ABORT_TO_STARSTAR; t_ch = *++text; }
@@ -134,8 +134,8 @@ static int dowild(const uchar *p, const uchar *text, int force_lower_case) p_ch = NEGATE_CLASS; #endif /* Assign literal TRUE/FALSE because of "matched" comparison. */ - special = p_ch == NEGATE_CLASS? TRUE : FALSE; - if (special) { + negated = p_ch == NEGATE_CLASS? TRUE : FALSE; + if (negated) { /* Inverted character class. */ p_ch = *++p; }
@@ -217,7 +217,7 @@ static int dowild(const uchar *p, const uchar *text, int force_lower_case) } else if (t_ch == p_ch) matched = TRUE; } while (prev_ch = p_ch, (p_ch = *++p) != ']'); - if (matched == special || t_ch == '/') + if (matched == negated || t_ch == '/') return NOMATCH; continue; }
--
1.8.0.rc2.23.g1fb49df