Re: [PATCH 2/8] wildmatch: rename constants and update prototype
From: Junio C Hamano <hidden>
Date: 2016-06-15 22:55:35
Nguyễn Thái Ngọc Duy [off-list ref] writes:
quoted hunk
@@ -134,101 +131,102 @@ static int dowild(const uchar *p, const uchar *text, int force_lower_case) p_ch = NEGATE_CLASS; #endif /* Assign literal TRUE/FALSE because of "matched" comparison. */ - special = p_ch == NEGATE_CLASS? TRUE : FALSE; + special = p_ch == NEGATE_CLASS;
Leftover comment needs to be reworded as well???
if (special) {
/* Inverted character class. */
p_ch = *++p;
}I'd prefer "special" used in the "case '['" given a more sensible name here.