Re: [PATCH] For git-subtree, when installing docs (make install-doc), create man1 folder first.
From: Junio C Hamano <hidden>
Date: 2016-06-15 22:55:31
"Jesper L. Nielsen" [off-list ref] writes:
From: "Jesper L. Nielsen" <redacted> Hi.. I installed Git subtree and discovered that the if the man1dir doesn't exist the man-page for Git Subtree is just called man1. So, small patch to create the folder first in the Makefile. Hope everything is right with the patch and submitting of the patch. Best Regards Jesper Signed-off-by: Jesper L. Nielsen <redacted> --- contrib/subtree/Makefile | 1 + 1 file changed, 1 insertion(+)
This is a good first step in the right direction, I think. Shouldn't the install targets take DESTDIR into account like the main Makefile does, though? As to the patch submission, everything below "---" line looks sane, but please check how others write commit log messages by browsing a handful of entries in "git log --no-merges" output and notice the difference (the details are found in Documentation/SubmittingPatches). Thanks.
quoted hunk
diff --git a/contrib/subtree/Makefile b/contrib/subtree/Makefile index 05cdd5c..a341cf4 100644 --- a/contrib/subtree/Makefile +++ b/contrib/subtree/Makefile@@ -35,6 +35,7 @@ install: $(GIT_SUBTREE) install-doc: install-man install-man: $(GIT_SUBTREE_DOC) + mkdir -p $(man1dir) $(INSTALL) -m 644 $^ $(man1dir) $(GIT_SUBTREE_DOC): $(GIT_SUBTREE_XML)