Thread (4 messages) flat view 4 messages, 3 authors, 2016-06-15

Re: [PATCH] git-clean: Display more accurate delete messages

From: Soren Brinkmann <hidden>
Date: 2016-06-15 22:55:29

Hi,

On Thu, Dec 06, 2012 at 09:37:31AM -0800, Junio C Hamano wrote:
Zoltan Klinger [off-list ref] writes:
quoted
Only print out the names of the files and directories that got actually
deleted.

Consider the following repo layout:
  |-- test.git/
        |-- foo/
             |-- bar/
                  |-- bar.txt
             |-- frotz.git/
                  |-- frotz.txt
        |-- tracked_file1
        |-- untracked_file1
...
Consider the output of the improved version:

  $ git clean -fd
  Removed foo/bar/bar.txt
  Removed foo/bar
  Removed untracked_file1
Hrm, following your discussion (ellided above), I would have
expected that you would show

    Removing directory foo/bar
    Removing untracked_file1
Also it would be nice to have warnings about undeleted directories since this git
clean behavior (or the work around to pass -f twice) is not documented.
Without a warning you would probably miss that something was _not_ deleted.

So something like:
	Removing foo
	Removing bar
	...

	Warning: Not all untracked objects have been deleted:
	<list objects here> (optional)
	Use git clean --force --force to delete all objects.


But clearly going into a good direction. Thanks.

	Soren
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help