Re: [PATCH/RFC 1/5] mingw: make fgetc raise SIGINT if apropriate
From: Erik Faye-Lund <hidden>
Date: 2016-06-15 22:55:28
On Fri, Nov 30, 2012 at 7:11 PM, Jeff King [off-list ref] wrote:
On Fri, Nov 30, 2012 at 06:58:11PM +0100, Johannes Schindelin wrote:quoted
Hi, On Tue, 13 Nov 2012, Erik Faye-Lund wrote:quoted
Set a control-handler to prevent the process from terminating, and simulate SIGINT so it can be handled by a signal-handler as usual.One thing you might want to mention is that the fgetc() handling is not thread-safe, and intentionally so: if two threads read from the same console, we are in trouble anyway.That makes sense to me, but I'm confused why it is part of mingw_fgetc, which could in theory read from arbitrary streams, no? It it is not necessarily a console operation at all. I feel like I'm probably missing something subtle here...
I did add an early out for the non-console cases. Is this what you're missing, perhaps? -- *** Please reply-to-all at all times *** *** (do not pretend to know who is subscribed and who is not) *** *** Please avoid top-posting. *** The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free. You received this message because you are subscribed to the Google Groups "msysGit" group. To post to this group, send email to msysgit@googlegroups.com To unsubscribe from this group, send email to msysgit+unsubscribe@googlegroups.com For more options, and view previous threads, visit this group at http://groups.google.com/group/msysgit?hl=en_US?hl=en