Thread (19 messages) 19 messages, 8 authors, 2016-06-15

Re: Topics currently in the Stalled category

flat view

From: Nguyen Thai Ngoc Duy <hidden>
Date: 2016-06-15 22:55:23

Possibly related (same subject, not in this thread)

On Wed, Nov 21, 2012 at 7:05 AM, Junio C Hamano [off-list ref] wrote:
* nd/unify-appending-of-s-o-b (2012-11-15) 1 commit
 - Unify appending signoff in format-patch, commit and sequencer

 I am not sure if the logic to refrain from adding a sign-off based
 on the existing run of sign-offs is done correctly in this change.
I'm not sure what's the right logic here. The original code in
format-patch has exactly one test just to verify that --signoff does
_something_. There's another signoff code in git-am.sh and we should
make sure at least the behavior is consistent. I guess I should start
over by writing new tests to record the current behavior, then fixes
and finally the unification. I think you can drop this for now.
-- 
Duy
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help