Thread (6 messages) flat view 6 messages, 2 authors, 2016-06-15

Re: Failure to extra stable@vger.kernel.org addresses

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:55:22

Possibly related (same subject, not in this thread)

Krzysztof Mazur [off-list ref] writes:
On Tue, Nov 20, 2012 at 02:30:02PM -0800, Junio C Hamano wrote:
quoted
We should probably fix the tools that generate these bogus
non-addresses first.  What's wrong with

	Cc: stable kernel (v3.5 v3.6 v3.7) [off-list ref]

which should be OK?

Also I suspect that this should be also deemed valid:

	Cc: stable@vger.kernel.org (Stable kernel - v3.5 v3.6 v3.7)
So maybe we should just use the original regex:

$recipient =~ s/(.*>).*$/$1/

which does not add regression for valid addresses, and just fails
in some rare cases when '>' is used in garbage. It was sufficient
for original issue reported by, and tested by Felipe.

The problem with '>' would be fixed in separate patch. The same
problem exits for invalid address generated by --cc-cmd
(see [PATCH] git-send-email: don't return undefined value in
extract_valid_address()). We would report an error in both cases,
as suggested by Junio.
OK, sounds like a plan.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help