Re: [PATCH v2 4/6] completion: consolidate test_completion*() tests
From: Junio C Hamano <hidden>
Date: 2016-06-15 22:55:18
Felipe Contreras [off-list ref] writes:
quoted hunk ↗ jump to hunk
No need to have two versions; if a second argument is specified, use that, otherwise use stdin. Signed-off-by: Felipe Contreras <redacted> --- t/t9902-completion.sh | 30 +++++++++++++----------------- 1 file changed, 13 insertions(+), 17 deletions(-)diff --git a/t/t9902-completion.sh b/t/t9902-completion.sh index 204c92a..59cdbfd 100755 --- a/t/t9902-completion.sh +++ b/t/t9902-completion.sh@@ -60,19 +60,15 @@ run_completion () # 2: expected completion test_completion () { - test $# -gt 1 && echo "$2" > expected + if [ $# -gt 1 ]; then + echo "$2" > expected + else + sed -e 's/Z$//' > expected + fi &&
As "$2" could begin with dash, end with \c, etc. that possibly can be misinterpred by echo, I'd rewrite this as printf '%s\n' "$2" >expected Otherwise looked fine; thanks.