Re: [PATCH v4 0/4] Introduce diff.submodule
From: Jeff King <hidden>
Date: 2016-06-15 22:55:18
On Thu, Nov 15, 2012 at 08:23:34AM -0800, Jeff King wrote:
On Tue, Nov 13, 2012 at 09:12:43PM +0530, Ramkumar Ramachandra wrote:quoted
v1 is here: http://mid.gmane.org/1349196670-2844-1-git-send-email-artagnon@gmail.com v2 is here: http://mid.gmane.org/1351766630-4837-1-git-send-email-artagnon@gmail.com v3 is here: http://mid.gmane.org/1352653146-3932-1-git-send-email-artagnon@gmail.com This version was prepared in response to Peff's review of v3. What changed: * Functional code simplified and moved to git_diff_ui_config. * Peff contributed one additional patch to the series.Thanks, this version looks good to me.
Oh wait. I did not look closely enough. The point was to move the option parser _out_ of git_diff_ui_config into git_diff_basic_config, so that it only triggers for porcelain, not plumbing. -Peff