Re: Notes in format-patch
From: Junio C Hamano <hidden>
Date: 2016-06-15 22:55:16
Junio C Hamano [off-list ref] writes:
quoted hunk
As the topic seems to be already in Peff's next, here is a trivial fix for this in incremental form. -- >8 -- Subject: format-patch: add a blank line between notes and diffstat The last line of the note text comes immediately before the diffstat block, making the latter unnecessarily harder to view. Signed-off-by: Junio C Hamano <redacted> --- log-tree.c | 1 + 1 file changed, 1 insertion(+)diff --git i/log-tree.c w/log-tree.c index 712a22b..9303fd8 100644 --- i/log-tree.c +++ w/log-tree.c@@ -683,6 +683,7 @@ void show_log(struct rev_info *opt) opt->shown_dashes = 1; } strbuf_addstr(&msgbuf, ctx.notes_message); + strbuf_addch(&msgbuf, '\n'); } if (opt->show_log_size) {
... and it is broken X-<. The blank line should be added before the diffstat, not after the notes message (t3307 shows a case where we give notes without diffstat, and we shouldn't be adding an extra blank line in that case.