Thread (1 message) 1 message, 1 author, 2016-06-15

Re: Commit message problem of reverting multiple commits

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:55:16

乙酸鋰 [off-list ref] writes:
I ran git 1.8.0 command line

git revert --no-commit rev1 rev2

I see a prepared commit message like

Revert "<description from one commit>"
This reverts commit <SHA1 of one commit>.


The actual revert content is correct - it is all the relevant commits
that were selected. I expect the message to reflect this:

Revert "<description from commit1>", "<description from commit2>"
This reverts commits <SHA1 of commit1>, <SHA1 of commit2>.
Hrmph.  I actually think the revert-content is not correct.

I think the command should not take more than one commit on the
command line when --no-commit is in use in the first place (the same
thing can be said for cherry-pick).  After all, "git revert rev1
rev2" is to revert rev1 and then rev2 independently, so unless that
option is spelled "--squash", the resulting history should have two
commits that reverts rev1 and rev2 independently.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help