Re: [PATCH 2/3] diff: introduce diff.submodule configuration variable

Jeff King wrote:

On Sun, Nov 11, 2012 at 10:29:05PM +0530, Ramkumar Ramachandra wrote:

quoted

@@ -223,6 +238,15 @@ int git_diff_basic_config(const char *var, const char *value, void *cb)
              return 0;
      }

+     if (!strcmp(var, "diff.submodule")) {

Shouldn't this be in git_diff_ui_config so it does not affect scripts
calling plumbing?

I honestly didn't understand the difference between
git_diff_basic_config and git_diff_ui_config.  The latter function
calls the former function at the end of its body.  Why are they two
separate functions in the first place?

Btw, I just posted a follow-up.

Ram