Re: [PATCH] send-email: add proper default sender

On Tue, Nov 13, 2012 at 4:27 AM, Jeff King [off-list ref] wrote:

On Tue, Nov 13, 2012 at 01:54:59AM +0100, Felipe Contreras wrote:

quoted

quoted

But we use the environment to default the field, so the distinction
doesn't make much sense to me.  Plus, it has always been the case that
you can use git without setting user.*, but instead only using the
environment. I don't see any reason not to follow that principle here,
too.

And that's why a lot of commits end up like michael
<michael@michael-laptop.(none)>.

No, it's not. Those broken names do not come from the environment, but
from our last-resort guess of the hostname.

That depends how you define environment, but fine, the point is that it happens.

We long ago switched to
printing the name as a warning when we have made such a guess (bb1ae3f),
then more recently started rejecting them outright (8c5b1ae).

Right, but these would still happen:

michael [off-list ref]

quoted

Probably. But what I really want is to stop 'git send-email' from
asking. I think the one next step further can be done later.

But in the meantime you are causing a regression for anybody who expects
GIT_AUTHOR_NAME to override user.email when running git-send-email (and
you have taken away the prompt that they could have used to notice and
correct it).

I think they can survive. If anybody like this exists.

-- 
Felipe Contreras