Re: [PATCH] gitweb: git_summary - show $project in title
From: Jeff King <hidden>
Date: 2016-06-15 22:55:15
On Sun, Nov 11, 2012 at 06:20:58AM +0100, Henrich Schuchardt wrote:
quoted hunk ↗ jump to hunk
Gitweb pages are structured by divs of class title with grey background. The shortlog, and the log page show the project name as the first title. Page summary only shows an empty grey box above the project details. This provides an inconstent user experience. This patch adds the missing project title. Signed-off-by: Henrich Schuchardt <redacted> --- gitweb/gitweb.perl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl index 10ed9e5..3e1c452 100755 --- a/gitweb/gitweb.perl +++ b/gitweb/gitweb.perl@@ -6451,7 +6451,7 @@ sub git_summary { git_header_html(); git_print_page_nav('summary','', $head); - print "<div class=\"title\"> </div>\n"; + print "<div class=\"title\">$project</div>\n";
I do not have any opinion on whether the intent of the change is good or not, but shouldn't $project be run through esc_html() here? -Peff