Re: [PATCH 1/2] git-sh-setup: refactor ident-parsing functions

Jeff King [off-list ref] writes:

On Mon, Nov 12, 2012 at 12:08:37PM -0800, Junio C Hamano wrote:

quoted

Jeff King [off-list ref] writes:

quoted

Changing the interface for get_author_ident_from_commit would be a pain,
but if we just wanted to help filter-branch, we could do something like
this:

Yes, that is the direction I was alluding to.

Callers of get_author_ident_from_commit can also do the same and
avoid rebuilding the same $pick_author_script over and over again,
or get_author_ident_from_commit can do so for its callers.

I don't think get_author_ident_from_commit can do so on demand due to
the subshell issue I mentioned.

OK, that is what I obviously missed.

I wonder if we should simply generate these at build time and store them
in the script.

Yeah, my knee-jerk reaction was that it was wasteful to run script
at runtime to build a constant string, but the engineering cost may
not be worth it.