Re: [PATCH 0/5] Use string_lists when processing notes

On Tue, Nov 6, 2012 at 8:56 AM, Michael Haggerty [off-list ref] wrote:

On 11/04/2012 10:05 PM, Johan Herland wrote:

quoted

On Sun, Nov 4, 2012 at 8:07 AM, Michael Haggerty [off-list ref] wrote:

quoted

This simplifies the code.  Also, sort lines all at once (O(N lg N))
rather than insertion sorting as lines are processed (O(N^2)) and fix
the handling of empty values in GIT_NOTES_DISPLAY_REF and
GIT_NOTES_REWRITE_REF.

Michael Haggerty (5):
  string_list: add a function string_list_remove_empty_items()
  Initialize sort_uniq_list using named constant
  combine_notes_cat_sort_uniq(): sort and dedup lines all at once
  notes: fix handling of colon-separated values
  string_list_add_refs_from_colon_sep(): use string_list_split()

Series looks good to me.

Acked-by: Johan Herland <redacted>

Thanks for reviewing the series.

Was it intentional that you didn't CC the mailing list?

No, not at all. Sorry.

Here we go again, with the appropriate CC:

Acked-by: Johan Herland <redacted>


Have fun! :)

...Johan

-- 
Johan Herland, [off-list ref]
www.herland.net