Thread (25 messages) 25 messages, 6 authors, 2016-06-15

Re: [PATCH v2] git-submodule add: Add -r/--record option.

From: Jeff King <hidden>
Date: 2016-06-15 22:55:08

On Sun, Oct 28, 2012 at 06:34:31PM -0400, W. Trevor King wrote:
On Sun, Oct 28, 2012 at 02:59:33PM -0700, Shawn Pearce wrote:
quoted
Looks like the Gerrit meaning is basically the same as Ævar's. Gerrit
updates the parent project as if you had done:

  $ git submodule foreach 'git checkout $(git config --file
$toplevel/.gitmodules submodule.$name.branch) && git pull'
  $ git commit -a -m "Updated submodules"
  $ git push
Ah, good, then we *are* all using the option for the same thing.
That makes me more comfortable. Your patch adds support for setting the
variable initially. Does it need any special magic for maintenance, or
is it something that would always be updated by hand?

Right now, the variable is not an official git-submodule thing and it is
OK to say "you are on your own by setting and using it from external
tools". But as soon as we support setting it in the first place, it is
reasonable to claim it as a bug if we do not keep it up to date for
certain operations.

I'm not familiar enough with the workflows around branching submodules
to know whether any such operations actually exist.

-Peff
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help